This repository has been archived by the owner on Sep 16, 2022. It is now read-only.
Remove glob to preserve binary back compatibility #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glob links with gnu libc version 2.27 if compiled on a modern system. This is due to the vulnerabilities found in its libc implementation, particularly CVE-2017-15670-1. This could lead to a buffer overflow if a `~` operator is used. Since glob is not directly used by monero, removing support for it seems to be the simplest way to deal with this in order to preserve binary compatibility accross a range of linux distributions. Together with the back compatibility code for monero this should set the required libc version at 2.17.
This was referenced Dec 2, 2018
moneromooo-monero
approved these changes
Dec 2, 2018
fluffypony
added a commit
that referenced
this pull request
Jun 8, 2019
f2a7b64 Remove glob to preserve binary back compatibility (TheCharlatan)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glob links with gnu libc version 2.27 if compiled on a modern system. This is due to the vulnerabilities found in its libc implementation, particularly CVE-2017-15670-1. This could lead to a buffer overflow if a
~operator is used. Since glob is not directly used by monero, removing support for it seems to be the simplest way to deal with this in order to preserve binary compatibility accross a range of linux distributions. Together with the back compatibility code for monero this should set the required libc version at 2.17.Please see discussion and comments on monero-project/monero#4929 before merging.