Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trezor: test fixes and improvements #5398

Merged
merged 2 commits into from
Apr 15, 2019
Merged

Trezor: test fixes and improvements #5398

merged 2 commits into from
Apr 15, 2019

Conversation

ph4r05
Copy link
Contributor

@ph4r05 ph4r05 commented Apr 4, 2019 •
edited
Loading

  • Tested blockchain hardforks modifiable via environment variable, default: test only HF 11
  • Hardfork switching fixes (e.g., rewind 10 blocks to apply v10 rules after switch)
  • Enable to change emulator and bridge ports via environment variables.

@ph4r05 ph4r05 mentioned this pull request Apr 4, 2019
Closed
31 tasks
@ph4r05 ph4r05 force-pushed the trezor/201903_trezor_tests branch 3 times, most recently from 317a7ba to 3c39d3d Compare April 8, 2019 15:08
@ph4r05
Copy link
Contributor Author

ph4r05 commented Apr 10, 2019

Sooo besides the resolved comment, the PR looks good? :)

@ph4r05
tests: trezor tests fixes and improvements
c97a1f7 
- configurable hardforks via env vars
@ph4r05 ph4r05 force-pushed the trezor/201903_trezor_tests branch from 3c39d3d to 5dd0d21 Compare April 10, 2019 15:00
@ph4r05 ph4r05 force-pushed the trezor/201903_trezor_tests branch from 5dd0d21 to 41901b8 Compare April 10, 2019 16:29
fluffypony
fluffypony approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@fluffypony fluffypony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@fluffypony fluffypony merged commit 41901b8 into monero-project:master Apr 15, 2019
fluffypony added a commit that referenced this pull request Apr 15, 2019
@fluffypony
Merge pull request #5398
e31559d 
41901b8 device/trezor: env-configurable ports (Dusan Klinec)
c97a1f7 tests: trezor tests fixes and improvements (Dusan Klinec)
@ph4r05 ph4r05 deleted the trezor/201903_trezor_tests branch April 15, 2019 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluffypony fluffypony fluffypony approved these changes

@moneromooo-monero moneromooo-monero moneromooo-monero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ph4r05 @fluffypony @moneromooo-monero