Build: protobuf fixes for docker, cross-compilation, monero-gui

[ph4r05]

Fixes /contrib/depends for protobuf so it works also in cross-compilation under docker.

Two packages are needed, native_protobuf and protobuf. native_protobuf builds protoc under host so it can use it to generate trezor messages. Native protoc is also used during build of the target host protobuf dependency.

Adds dependencies for GUI compilation. Changes to the monero-wallet-gui.pro file:

# REMOVE -lboost_thread from the LIBS list
TREZOR_LINKER = $$cat($$WALLET_ROOT/lib/trezor_link_flags.txt)
LIBS += $$TREZOR_LINKER -lboost_thread

[ph4r05]

Waiting how the tests end up...

@TheCharlatan could you pls test this one then? I recall you had some issues with protobuf deps so I am wondering if this can fix it. Thanks!

[ph4r05]

... still testing and fixing

[ph4r05]

@TheCharlatan I was wondering, can we make libusb compile also with mingw? It could work with --disable-udev.

[ph4r05]

Hmm same error here as described in protocolbuffers/protobuf#5358

[TheCharlatan]

You can add plattform specific rules like this:

define $(package)_set_vars
  $(package)_config_opts_mingw32=--disable-udev
endef

[ph4r05]

@TheCharlatan fix to the .travis.yml (posix alternative for gcc) seem to fix mingw problem. protocolbuffers/protobuf#5358

[TheCharlatan]

Great! Can you comment it on the issue, I'll close it then. Can you also add a line in the readme about selecting the posix alternative?

[ph4r05]

I will adopt the PR later today/tomorrow but it seems I have fully working compilation for all platforms with protobuf and libusb (still struggling with osx+libusb a bit but I will fix it soon)

[ph4r05]

The key point is probably to set both gcc and g++ to posix versions and to regenerate docker dependencies & clean rebuild.

[ph4r05]

OK The build works, but Travis failed as it didn't make it under 50 minutes time limit for Win64.

I am done on this from my side.

[ph4r05]

@TheCharlatan thanks for the approval! I had to do one small fix in the cmake now 😞

[ph4r05]

@TheCharlatan I've rebased on master. Could I ask you for the review? :)

[ph4r05]

@danrmiller could you pls check buildbot/monero-static-win32? It complains about some linking error on cmake.

C:/msys32/mingw32/bin/cmake.exe: error while loading shared libraries: ?: cannot open shared object file: No such file or directory
make: *** [Makefile:151: release-static-win32] Error 127

[ph4r05]

OK another cmake improvements. Now I've added stuff for GUI compilation.

[dEBRUYNE-1]

@ph4r05 - For the GUI compilation, have you also looked at necessary changes in the GUI repository? Specifically, the monero-wallet-gui.pro file.

[ph4r05]

@dEBRUYNE-1 it's only required to add:

TREZOR_LINKER = $$cat($$WALLET_ROOT/lib/trezor_link_flags.txt)
LIBS += $$TREZOR_LINKER

This is the simplest way I could think of. Trezor has variable dependencies, e.g. if there is a compatible libusb library present, it uses it. The file trezor_link_flags.txt contains linker flags which should be used for trezor deps. Cmake copies all dependencies to $$WALLET_ROOT/lib so the linking works correctly.

I am also having issues with -lboost_thread-mt which yields the following linking error:

Undefined symbols for architecture x86_64:
  "boost::this_thread::hidden::sleep_until(timespec const&)", referenced from:
      boost::this_thread::sleep(boost::posix_time::ptime const&) in libwallet_merged.a(miner.cpp.o)
  "boost::this_thread::hidden::sleep_for(timespec const&)", referenced from:
      boost::this_thread::sleep_for(boost::chrono::duration<long long, boost::ratio<1l, 1000000000l> > const&) in libwallet_merged.a(wallet_manager.cpp.o)
      boost::this_thread::sleep_for(boost::chrono::duration<long long, boost::ratio<1l, 1000000000l> > const&) in libepee.a(mlocker.cpp.o)
      boost::this_thread::sleep_for(boost::chrono::duration<long long, boost::ratio<1l, 1000000000l> > const&) in libwallet_merged.a(wallet2.cpp.o)
      boost::this_thread::sleep_for(boost::chrono::duration<long long, boost::ratio<1l, 1000000000l> > const&) in libwallet_merged.a(dns_utils.cpp.o)
      boost::this_thread::sleep_for(boost::chrono::duration<long long, boost::ratio<1l, 1000000000l> > const&) in libwallet_merged.a(node_rpc_proxy.cpp.o)
      boost::this_thread::sleep_for(boost::chrono::duration<long long, boost::ratio<1l, 1000000000l> > const&) in libwallet_merged.a(miner.cpp.o)
      boost::this_thread::sleep_for(boost::chrono::duration<long long, boost::ratio<1l, 1000000000l> > const&) in libwallet_merged.a(transport.cpp.o)
      ...
ld: symbol(s) not found for architecture x86_64

I had to switch it to -lboost_thread.

To get the GUI working with the Trezor I need a few more modifications (key image sync), which I will add as a separate PR.

[dEBRUYNE-1]

Thanks for the clarification. I am, alas, not sufficiently knowledgeable to assist / help you with your building issues.

[danrmiller]

@danrmiller could you pls check buildbot/monero-static-win32? It complains about some linking error on cmake.

C:/msys32/mingw32/bin/cmake.exe: error while loading shared libraries: ?: cannot open shared object file: No such file or directory
make: *** [Makefile:151: release-static-win32] Error 127

@ph4r05 Thanks, it builds now, just looks like I still need to look at something with a temp file in use during the tests.
https://build.getmonero.org/builders/monero-static-win32/builds/5820

[ph4r05]

@dEBRUYNE-1 thanks. I have it building OK now. Now I just need to connect Trezor features to the GUI :)

[ph4r05]

@danrmiller thanks for fixing the build. This test failure is quite common. It is present also on other architectures and I think quite old.

[ph4r05]

I've created corresponding PR in monero-gui: monero-project/monero-gui#1838