core: sync database based on bytes added, not blocks added #4204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoffu
reviewed
Aug 9, 2018
src/cryptonote_core/blockchain.cpp
Outdated
| @@ -3877,11 +3877,13 @@ bool Blockchain::cleanup_handle_incoming_blocks(bool force_sync) | |||
| store_blockchain(); | |||
| m_sync_counter = 0; | |||
| } | |||
| else if (m_db_blocks_per_sync && m_sync_counter >= m_db_blocks_per_sync) | |||
| else if ((m_db_sync_on_blocks && m_sync_counter >= m_db_sync_threshold) || (!m_db_sync_on_blocks && m_bytes_to_sync >= m_db_sync_threshold)) | |||
There was a problem hiding this comment.
Since m_db_blocks_per_sync is now named as m_db_sync_threshold , shouldn't this if statement also check for m_db_sync_threshold && (...) in order to preserve the logic?
019b979 to
44d1745
Compare
stoffu
approved these changes
Aug 9, 2018
Blocks have a very wide range, whereas actual size is the relevant quantity to consider when syncing
44d1745 to
b278b83
Compare
|
I just bumped the default by 2.5, 300 MB is not that large and better performance. |
stoffu
approved these changes
Aug 12, 2018
luigi1111
added a commit
that referenced
this pull request
Aug 23, 2018
b278b83 core: sync database based on bytes added, not blocks added (moneromooo-monero)
This was referenced Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocks have a very wide range, whereas actual size is the relevant
quantity to consider when syncing