wallet: disable core dumps on startup in release mode #4136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoffu
reviewed
Aug 10, 2018
| @@ -51,6 +51,9 @@ bool isAddressLocal(const std::string &address) | |||
| void onStartup() | |||
| { | |||
| tools::on_startup(); | |||
| #ifdef NDEBUG | |||
| tools::disable_core_dumps(); | |||
| #endif | |||
There was a problem hiding this comment.
How about just bring this into tools::on_startup()?
There was a problem hiding this comment.
It'd disable for every program, and I want to disable it just for wallets (for secret keys).
stoffu
reviewed
Aug 10, 2018
src/common/util.cpp
Outdated
| struct rlimit rlimit; | ||
| rlimit.rlim_cur = rlimit.rlim_max = 0; | ||
| if (setrlimit(RLIMIT_CORE, &rlimit)) | ||
| MWARNING("Failed to disable core dumps"); |
There was a problem hiding this comment.
Maybe return false in case of failure?
stoffu
reviewed
Aug 10, 2018
src/common/util.cpp
Outdated
| @@ -677,6 +678,17 @@ std::string get_nix_version_display_string() | |||
| signal(SIGILL, posix_crash_handler); | |||
| signal(SIGFPE, posix_crash_handler); | |||
| } | |||
| bool disable_core_dumps() | |||
There was a problem hiding this comment.
This needs to be defined outside the #ifdef STACK_TRACE section, otherwise the symbol will be undefined when STACK_TRACE is not defined (buildbot is failing due to this).
066ca23 to
4307489
Compare
stoffu
approved these changes
Aug 12, 2018
luigi1111
added a commit
that referenced
this pull request
Aug 15, 2018
4307489 wallet: disable core dumps on startup in release mode (moneromooo-monero)
This was referenced Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.