Fix translations header generation when cross-compilating #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define generate_translations_header as an external project to be able to use the compilation toolchain for the host instead of the toolchain for the target.
| ExternalProject_Add(generate_translations_header | ||
| SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/translations" | ||
| BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/translations" | ||
| INSTALL_COMMAND cmake -E echo "") |
There was a problem hiding this comment.
What does this bit with echo do ?
There was a problem hiding this comment.
The build failed when INSTALL_COMMAND was not set or set to an empty string as apparently ExternalProject requires an install step even if in this case there is nothing to install.
So as a workaround I set INSTALL_COMMAND to a command doing nothing that should be available on all architectures (printing an empty message using cmake).
moneromooo-monero
approved these changes
Jan 4, 2018
fluffypony
added a commit
that referenced
this pull request
Jan 10, 2018
f035478 Fix translations header generation when cross-compilating (Guillaume LE VAILLANT)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define generate_translations_header as an external project to be able
to use the compilation toolchain for the host instead of the toolchain
for the target.