Skip to content

Commit

Permalink
Bug fixed and added badge to readme
Browse files Browse the repository at this point in the history
  • Loading branch information
davidebianchi committed May 15, 2016
1 parent f683e8c commit 039c3d0
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 3 deletions.
9 changes: 9 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
[![npm version](https://badge.fury.io/js/code-push-travis-cli.svg)](https://badge.fury.io/js/code-push-travis-cli)
[![Build Status](https://travis-ci.org/mondora/code-push-travis-cli.svg?branch=master)](https://travis-ci.org/mondora/code-push-travis-cli)
[![Dependency Status](https://david-dm.org/mondora/code-push-travis-cli.svg)](https://david-dm.org/mondora/code-push-travis-cli)
[![devDependency Status](https://david-dm.org/mondora/code-push-travis-cli/dev-status.svg)](https://david-dm.org/mondora/code-push-travis-cli#info=devDependencies)

# code-push-travis-cli

code-push script for travis-ci.
Expand All @@ -18,3 +23,7 @@ install:
script:
- code-push-travis
```
## Todo
Add option for deployment name.
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "code-push-travis-cli",
"version": "1.0.3",
"version": "1.0.4",
"description": "Automatic ci deploy of react-native app with code-push",
"main": "lib/index.js",
"bin": {
Expand Down
2 changes: 1 addition & 1 deletion src/steps/deploy-android.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ function targetBinary () {
}

export default function codepushAndroidDeploy (argv) {
sh(`code-push release-react ${pkg.name}-android android --des ${argv.description} -m ${argv.mandatory} ${targetBinary(argv)}`, {stdio: [0, 1, 2]});
sh(`code-push release-react ${pkg.name}-android android --des "${argv.description}" -m ${argv.mandatory} ${targetBinary(argv)}`, {stdio: [0, 1, 2]});
sh(`code-push deployment ls ${pkg.name}-android`, {stdio: [0, 1, 2]});
}
2 changes: 1 addition & 1 deletion src/steps/deploy-ios.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ function targetBinary () {

export default function codepushIOSDeploy (argv) {
// Added fixed binaryVersion: https://github.com/Microsoft/code-push/pull/222
sh(`code-push release-react ${pkg.name}-ios ios --des ${argv.description} -m ${argv.mandatory} -t ${targetBinary()}`, {stdio: [0, 1, 2]});
sh(`code-push release-react ${pkg.name}-ios ios --des "${argv.description}" -m ${argv.mandatory} -t ${targetBinary()}`, {stdio: [0, 1, 2]});
sh(`code-push deployment ls ${pkg.name}-ios`, {stdio: [0, 1, 2]});
}

0 comments on commit 039c3d0

Please sign in to comment.