⭐️ newcnspec bundle lint cmd
#253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cnspec bundle validate should also warn when queries are not assigned |
15d0562 to
0b118df
Compare
cnspec bundle validate cmd cnspec bundle validate cmd
0b118df to
6fb0278
Compare
cnspec bundle validate cmd cnspec bundle lint cmd
2096367 to
ef9af5c
Compare
ef9af5c to
8c7e66a
Compare
chris-rock
added a commit
to mondoohq/cnspec-policies
that referenced
this pull request
Jan 2, 2023
The new linter mondoohq/cnspec#253 found a few issues in the yaml files where tags have been used twice.
8c7e66a to
47e7cca
Compare
- extends the `cnspec bundle validate` cmd to check for unique policy and query ids - sarif output for cnspec bundle lint - add line number output for issues so that it is easier to track down issues in bundles
47e7cca to
9a2f261
Compare
jaym
approved these changes
Jan 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
As a developer of policies I want to verify that my developed bundle meets the requirements and conforms to best-practices.
Solution:
The new
cnspec bundle lintcommand (previously calledcnspec bundle validateships with a set of rules:A major improvement compared to the previous implementation is the detection of file name and line number. The allows the output to highlights the rule id and message with the file and line number. To see the new linting output, just run:
The new
cnspec bundle lintalso allows users to export the output as sarif with the-o sarifoption. Best is to pipe the output into a file:The report can then be viewed in Visual Studio Code and the Sarif Extension
We also improved renamed
cnspec bundle uploadtocnspec bundle publish.