🧹 Fixes double mql issues: Mondoo Linux Policy #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manuel Weber <manuel@mondoo.com>
Signed-off-by: Manuel Weber <manuel@mondoo.com>
Signed-off-by: Manuel Weber <manuel@mondoo.com>
Signed-off-by: Manuel Weber <manuel@mondoo.com>
Signed-off-by: Manuel Weber <manuel@mondoo.com>
Signed-off-by: Manuel Weber <manuel@mondoo.com>
Signed-off-by: Manuel Weber <manuel@mondoo.com>
Signed-off-by: Manuel Weber <manuel@mondoo.com>
Signed-off-by: Manuel Weber <manuel@mondoo.com>
Signed-off-by: Manuel Weber <manuel@mondoo.com>
Signed-off-by: Manuel Weber <manuel@mondoo.com>
Signed-off-by: Manuel Weber <manuel@mondoo.com>
Signed-off-by: Manuel Weber <manuel@mondoo.com>
Signed-off-by: Manuel Weber <manuel@mondoo.com>
Signed-off-by: Manuel Weber <manuel@mondoo.com>
HRouhani
approved these changes
Jul 1, 2024
HRouhani
reviewed
Jul 1, 2024
| @@ -419,7 +419,7 @@ queries: | |||
| && properties.sourceAddressPrefix == /\*|0\.0\.0\.0|<nw>\/0|\/0|internet|any/ | |||
| ) | |||
| allNsgTCP.all(properties.destinationPortRange != "*") | |||
| props.disallowedPortsRDP { | |||
| props.disallowedPortsRDPMondoo { | |||
There was a problem hiding this comment.
Thanks Manuel. I couldn't get why you changed the Azure properties name as we already considered the uniqueness of properties's name in the first place.
Beside if you justify the reasoning, then the name should also be reflected in the query!!!
example:
allNsgTCP.none(destinationPortRange.any(fromPort <= disallowedPortRDP && toPort >= disallowedPortRDPMondoo))
| @@ -2183,7 +2183,7 @@ queries: | |||
| ) | |||
| ) | |||
| allNsgUDP.all(securityRules.all(properties.destinationPortRange != "*")) | |||
| props.disallowedPortsUDP { | |||
| props.disallowedPortsUDPMondoo { | |||
There was a problem hiding this comment.
same problem here, and overall!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses unique
uid:for allprops.values to make it different from other policies.