New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⭐️ Microsoft 365 Security Policy #136

Merged

atomic111 merged 9 commits into main from hossein/ms365-policy

Mar 2, 2023

Contributor

HRouhani commented Feb 27, 2023

ms365 related policies which check/test some of the most important security aspects of ms365!


          added the ms365 policies

54f91b0

Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>

HRouhani requested a review from atomic111

February 27, 2023 15:23

HRouhani assigned atomic111

This comment has been minimized.

Sign in to view

chris-rock previously requested changes

View reviewed changes

Member

chris-rock left a comment

@HRouhani great first version. This PR requires some changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

chris-rock changed the title ~~ms365 policies~~ ⭐️ Micorosft 365 Secuirty Policy

chris-rock changed the title ~~⭐️ Micorosft 365 Secuirty Policy~~ ⭐️ Microsofot 365 Secuirty Policy

chris-rock changed the title ~~⭐️ Microsofot 365 Secuirty Policy~~ ⭐️ Microsoft 365 Secuirty Policy


          added the ms365 policies

7a5e92c

Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>

This comment has been minimized.

Sign in to view

tas50 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

tas50 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

tas50 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

tas50 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

chris-rock changed the title ~~⭐️ Microsoft 365 Secuirty Policy~~ ⭐️ Microsoft 365 Security Policy

tas50 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

tas50 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

tas50 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

tas50 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

tas50 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

tas50 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

tas50 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

tas50 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

tas50 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

tas50 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

tas50 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

tas50 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

tas50 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

tas50 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

tas50 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

tas50 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

Member

tas50 commented Feb 27, 2023

I left a number of updates for the naming. The product is Microsoft 365. We should use the full name when writing it in a sentence.

There are also several places we're telling the users to "click" on things. That should be "select" since it could be a screen reader.


          improved the Microsoft 365 security policies

6300c26

Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>

This comment has been minimized.

Sign in to view

atomic111 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

atomic111 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

atomic111 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

atomic111 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

atomic111 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

atomic111 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved

atomic111 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Show resolved Hide resolved

atomic111 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved


          improved the Microsoft 365 security policies

9c60d58

Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>

This comment has been minimized.

Sign in to view


          improved the Microsoft 365 security policies

a804dda

Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>

This comment has been minimized.

Sign in to view

atomic111 reviewed

View reviewed changes

core/mondoo-ms365-security.mql.yaml Outdated Show resolved Hide resolved


          improved the Microsoft 365 security policies

fad0a69

Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>

This comment has been minimized.

Sign in to view


          improved the Microsoft 365 security policies

8fe2e98

Signed-off-by: Hossein Rouhani <h_rouhani@hotmail.com>

This comment has been minimized.

Sign in to view

chris-rock and others added 2 commits

February 28, 2023 14:53


          🧹 update spell-check

67aa530


          Merge branch 'main' into hossein/ms365-policy

5fd2aac

HRouhani requested a review from chris-rock

February 28, 2023 20:21

atomic111 approved these changes

View reviewed changes

atomic111 approved these changes

View reviewed changes

atomic111 dismissed chris-rock’s stale review

March 2, 2023 14:03

your feedback has been incorporated

atomic111 merged commit 5c27d52 into main

atomic111 deleted the hossein/ms365-policy branch

March 2, 2023 14:04

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet