Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move toolbar extender to embedded package #40

Merged
merged 3 commits into from
Mar 3, 2023
Merged

move toolbar extender to embedded package #40

merged 3 commits into from
Mar 3, 2023

Conversation

TomMoore515
Copy link
Contributor

Description

Move toolbar extender to embedded package to fix bug

Motivation and Context

Fixes error when users without git try and use SDK

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@longda longda self-assigned this Mar 3, 2023
@longda longda self-requested a review March 3, 2023 18:19
longda
longda approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@longda longda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added version bumps. Watching build results from automation. Will merge after all clear there.

@longda longda added the bug Something isn't working label Mar 3, 2023
@longda longda merged commit 23e7ce4 into main Mar 3, 2023
@longda longda deleted the hotfix/toolbar-dependency-source-fix branch March 3, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@longda longda longda approved these changes

Assignees

@longda longda

@TomMoore515 TomMoore515

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomMoore515 @longda