-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reclassify EDS in MONDO #92
Comments
@pnrobinson what about using the following def: I can do a pull request, if you agree. I can remove the synonyms. Should we add EDS as a syn too? |
This definition is a LOT better, let's go for it! |
Cool, I'll make a PR. Thanks @pnrobinson! |
@cmungall I am getting a weird diff when I edit the MONDO file: diff --git a/src/ontology/mondo-edit.obo b/src/ontology/mondo-edit.obo [Term] |
is this done? |
I think I made a mistake here - I added the def and syn to MONDO_0012114 Ehlers-Danlos syndrome, Beasley-Cohen type, not MONDO_0020066 'Ehlers-Danlos syndrome'. I will fix this later. |
the defs above are fixed now in PR #105. I think we still need to take a closer look at the EDS classification though, I think that is what @pnrobinson is asking for. |
Per @pnrobinson, we should reclassify EDS using the latest classification: https://www.ehlers-danlos.com/2017-eds-international-classification/
Then, we should create a bucket under the main EDS that is something like
"uncertain", "n=1", "controverisal" -- not sure about the best name. Another strategy wouyld be to remove these cases completely from the main Monarch website and
to show a button that there are n=1 cases related to EDS that the user can get to with another mouse click.
The text was updated successfully, but these errors were encountered: