Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some xrefs map to multiple mondo terms #841

Closed
dst1 opened this issue Sep 28, 2019 · 1 comment
Closed

Some xrefs map to multiple mondo terms #841

dst1 opened this issue Sep 28, 2019 · 1 comment
Assignees
Labels
obsolete This includes both obsolete and merge requests xref

Comments

@dst1
Copy link

dst1 commented Sep 28, 2019

I hope this is the right place and way to reference this issues.

I'm using the MONDO ontology json from obofoundry downloaded at 26.09.2019
I found 4 cases where a single xref maps to multiple MONDO terms (presented here in json like form):

{
  "HP:0001651": [
    "MONDO:0015661",
    "MONDO:0004823"
  ],
  "HP:0000010": [
    "MONDO:0001650",
    "MONDO:0005247"
  ],
  "MESH:D006524": [
    "MONDO:0025085",
    "MONDO:0006011"
  ],
  "HP:0001941": [
    "MONDO:0006022",
    "MONDO:0041261"
  ]
}

Specifically:

  • MONDO:0015661 and MONDO:0004823 are both the same as HP:0001651 (semantically) however are found in different places at the ontology tree. Also, MONDO:0004823 should be labeled with Orphanet:1666.
  • HP:0000010 - is neither MONDO:0001650 nor MONDO:0005247 as it is recurrent. I couldn't find a suitable alternative in HPO. Medically, MONDO:0001650 should be a descendant of MONDO:0005247 as it is an infection of a bladder. This will solve another placement issue of MONDO:0001777 found under both of these.
  • MONDO:0006011 includes both viral hepatitis in humans and animals - MESH:D006524, MESH:D006525, MONDO:0025085 is exactly MESH:D006524 (animals). I'm not sure how and if this can be resolved.
  • MONDO:0006022 is exactly HP:0001941 while MONDO:0041261 can also potentially include alkalosis and so shouldn't refer to HP:0001941.

also the MESH urls on the site are broken:
https://meshb.nlm.nih.gov/record/ui?name={ID}
instead of the working:
https://meshb.nlm.nih.gov/record/ui?ui={ID}

@nicolevasilevsky
Copy link
Member

Thanks @dst1!

  1. I think MONDO:0015661 'dextrocardia (disease)' and MONDO:0004823 dextrocardia should be merged. @cmungall or others, any objections?
  2. I agree, I will make these edits on a branch and do PR:
  • remove HP_0000010 'Recurrent urinary tract infections' as a dbxref from MONDO:0001650 'acute cystitis (disease)' and MONDO:0005247 'urinary tract infection (disease)'.
  • move MONDO:0001650 'acute cystitis (disease)' to a child of MONDO:0005247 'urinary tract infection (disease)'.
  1. MESH:D006524 is labeled as MONDO:NonHumanEquivalent. I feel like this addresses this issue, no?
  2. I will remove HP: 0001941 as an dbxef to MONDO:0041261 'disorder of acid-base balance'

@nicolevasilevsky nicolevasilevsky added the obsolete This includes both obsolete and merge requests label Sep 30, 2019
nicolevasilevsky added a commit that referenced this issue Sep 30, 2019
…om MONDO:0001650 'acute cystitis (disease)' and MONDO:0005247 'urinary tract infection (disease)'. Addresses #841
nicolevasilevsky added a commit that referenced this issue Sep 30, 2019
…5247 'urinary tract infection (disease)'. Addresses #841
nicolevasilevsky added a commit that referenced this issue Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
obsolete This includes both obsolete and merge requests xref
Projects
None yet
Development

No branches or pull requests

2 participants