Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ontology Access Kit in OxoEndpoint methods #6

Merged
merged 3 commits into from
Apr 18, 2022
Merged

Use Ontology Access Kit in OxoEndpoint methods #6

merged 3 commits into from
Apr 18, 2022

Conversation

pkalita-lbl
Copy link
Member

These changes delegate the real work within the OxoEndpoint methods to an OlsImplementation object from Ontology Access Kit.

I noticed as I was testing that the PNGs generated by the mapcrawl examples in the README using this branch look different than they look in the saved output images presented in the README. But they do look the same as when running the examples in the main branch. So perhaps something with the upstream services has changed since those output images were saved.

There are also some somewhat unrelated changes in here that convert the test files into unttest.TestCase classes.

@pkalita-lbl pkalita-lbl requested a review from cmungall April 15, 2022 20:54
@cmungall
Copy link
Member

yes, quite possible something changed in the upstream services

@cmungall cmungall merged commit 952596f into main Apr 18, 2022
@cmungall cmungall deleted the use-oak branch April 18, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants