Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: お品書きに画像を追加、他 #854

Merged
merged 9 commits into from
Jan 23, 2025
Merged

update: お品書きに画像を追加、他 #854

merged 9 commits into from
Jan 23, 2025
+31 −23

Conversation

momocus
Copy link
Owner

@momocus momocus commented Jan 19, 2025 •
edited
Loading

Close #834

  • お品書きに画像を追加
  • 新着アイコンは酒名の先頭に
  • デザインをよしなに

モバイル

image

PC

image

@momocus
update: お品書きに画像を追加、他
002dfac 
- 新着アイコンは酒名の先頭に
- デザインをよしなに
@momocus momocus linked an issue Jan 19, 2025 that may be closed by this pull request
お品書きに画像が欲しい #834
Closed
@github-actions github-actions bot requested a review from yonta January 19, 2025 06:56
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 19, 2025 •
edited
Loading

📦 esbuild Bundle Analysis for sakazuki

This analysis was generated by esbuild-bundle-analyzer. 🤖
This PR introduced no changes to the esbuild bundle! 🙌

yonta
yonta requested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@yonta yonta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1+N問題の対処は必須で

app/views/sakes/_menu_one_drink.html.erb Outdated Show resolved Hide resolved
app/views/sakes/_menu_one_drink.html.erb Outdated Show resolved Hide resolved
app/views/sakes/_menu_one_drink.html.erb Outdated Show resolved Hide resolved
app/views/sakes/_menu_one_drink.html.erb Outdated Show resolved Hide resolved
@yonta
Copy link
Collaborator

yonta commented Jan 20, 2025 •
edited
Loading

flexを巧みに使っていい感じのデザインにしたコミットをプッシュしました。
ぜひ使ってみてほしい。

@momocus
fix: タイトルだけリンクに
5479e7b 
画像をリンクにすると当たり判定がでかすぎるので
@momocus
update: 酒メニューの取得時にphotosをincludeしてN+1問題を解消
703b677
@momocus
fix: each_sliceを削除
ebbea51 
多分このころgrid layoutを理解していなかったんだと思う
yonta
yonta requested changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@yonta yonta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

順番が壊れました！

app/views/sakes/menu.html.erb Outdated Show resolved Hide resolved
app/views/sakes/_menu_one_drink.html.erb Outdated Show resolved Hide resolved
@yonta yonta force-pushed the 834-お品書きに画像が欲しい branch from 86cae8b to 3e2f2c4 Compare January 20, 2025 15:47
momocus and others added 2 commits January 23, 2025 12:53
@momocus @yonta
順番を保持するためeachに
5c86ce7 
Co-authored-by: SAITOU Keita <keita44.f4@gmail.com>
@momocus @yonta
sakes_controller.rb を更新
db13b99 
Co-authored-by: SAITOU Keita <keita44.f4@gmail.com>
@momocus momocus requested a review from yonta January 23, 2025 03:57
yonta
yonta approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@yonta yonta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

お疲れ様！お品書きがかっこよく！ 👍

@yonta yonta merged commit 6fe9d14 into main Jan 23, 2025
5 checks passed
@yonta yonta deleted the 834-お品書きに画像が欲しい branch January 23, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yonta yonta yonta approved these changes

Assignees

@momocus momocus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

お品書きに画像が欲しい
2 participants
@momocus @yonta