+Optional arg cleanup in horizontal param code #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up 13 falsely optional or unused arguments in the horizontal parameterization code, and related changes. This includes: - Made the previously optional OBC pointer arguments that were always being used in calls to 3 routines in MOM_lateral_mixing_coeffs.F90 into mandatory arguments. Because these are pointers, the deciding factor of whether to use them is really whether they are associated. - Made an internal optional argument that was always being used mandatory in 2 routines in MOM_internal_tides.F90. - Made 2 internal optional arguments that were always being used mandatory in thickness_diffuse_full(). - Eliminated the unused deta_tidal_deta argument to calc_tidal_forcing() and made the m_to_Z argument to the same routine mandatory. The former value is instead obtained by a call to tidal_sensitivity. - Eliminated 3 unused arguments and made an optional argument that was always used mandatory for find_deficit_ratios() in MOM_regularize_layers.F90.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1530 +/- ##
=========================================
Coverage 29.09% 29.10%
=========================================
Files 239 239
Lines 71568 71524 -44
=========================================
- Hits 20825 20818 -7
+ Misses 50743 50706 -37
Continue to review full report at Codecov.
|
|
Gaea regression: https://gitlab.gfdl.noaa.gov/ogrp/MOM6/-/pipelines/13914 ✔️ |
marshallward
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up 13 falsely optional or unused arguments in the horizontal
parameterization code, and related changes. This includes:
in calls to 3 routines in MOM_lateral_mixing_coeffs.F90 into mandatory
arguments. Because these are pointers, the deciding factor of whether to use
them is really whether they are associated.
routines in MOM_internal_tides.F90.
thickness_diffuse_full().
made the m_to_Z argument to the same routine mandatory. The former value is
instead obtained by a call to tidal_sensitivity.
used mandatory for find_deficit_ratios() in MOM_regularize_layers.F90.