+Eliminate unused arguments in diagnostics code #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliminated the unused optional OBC argument to write_energy() and several unused optional arguments to wave_speed() and wave_speeds() that are set instead via arguments to wave_speed_init() that store these values in a wave_speed_CS type. Also made the optional row_scale argument to tridiag_det() and the tracer_CSp argument to write_energy() that were always present in calls into mandatory arguments. All answers are bitwise identical, and solutions do not change.
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #1526 +/- ##
============================================
+ Coverage 29.08% 29.09% +0.01%
============================================
Files 239 239
Lines 71582 71566 -16
============================================
+ Hits 20821 20825 +4
+ Misses 50761 50741 -20
Continue to review full report at Codecov.
|
marshallward
approved these changes
Oct 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminated the unused optional OBC argument to write_energy() and several
unused optional arguments to wave_speed() and wave_speeds() that are set instead
via arguments to wave_speed_init() that store these values in a wave_speed_CS
type. Also made the optional row_scale argument to tridiag_det() and the
tracer_CSp argument to write_energy() that were always present in calls into
mandatory arguments. All answers are bitwise identical, and solutions do not
change.