Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Tab key navigation of panel #10

Closed
vinsworldcom opened this issue Sep 23, 2022 · 2 comments
Closed

Feature Request - Tab key navigation of panel #10

vinsworldcom opened this issue Sep 23, 2022 · 2 comments

Comments

@vinsworldcom
Copy link

Currently, when the panel is displayed, it seems nothing has focus. When I launch the panel, typing does nothing anywhere. I would expect perhaps focus could be set on the query text box so typing would immediately enter a query rather than having to mouse click on the query text box to start typing.

If I'm in the query text box, Tab enters an actual tab character. Are tabs required / supported in Remes Query Language? If spaces can be used instead, suggest that Tab key is used to switch to the next UI element (tabstops) as is typically the case in GUI applications.

  1. Query text box
  2. Submit query button
  3. Query to CS button
  4. Save Query res button
  5. View all subtrees checkbox
  6. tree view
  7. Current Path button
  8. current path text box
  9. ... back to beginning (query text box)

Cheers.

@molsonkiko
Copy link
Owner

Hi Vince, I agree that all the issues you described are frustrating. Unfortunately, there doesn't seem to be a good way to implement any of those proposals.

I have tab stops on all of the controls, I explicitly set the AcceptsTab parameter of the query box to false, which is supposed to make it so that Tab navigates to the next control in the tab order, and I tried adding a line that activates the query box when the tree viewer is initialized. Nothing works.

FWIW, I looked at CSVLint and CSV Query, two other C# plugins that have dockable controls, and they have the same issue you just articulated where you can use tabs for all the undocked forms (e.g., the settings form) but you can't use tabs for any of the docked forms (e.g., query box for CSV Query). It's probably just an issue with how Windows Forms integrates with Notepad++.

I'm not going to close this issue, because it may be worth revisiting in the future, but I don't think it's solvable without some pretty involved work on the underlying infrastructure.

@molsonkiko molsonkiko added wontfix This will not be worked on and removed wontfix This will not be worked on labels Sep 23, 2022
molsonkiko added a commit that referenced this issue Sep 24, 2022
ADDED
1. `Refresh` button for resetting the form with the JSON in the currently active buffer (resolves Issue #13).
2. __Tree view enhancements__ (resolves Issue #10):
	- Clicking on a tree node to expand it also changes the displayed node path and snaps the caret.
	- `Tab` can be used to switch between controls on the tree form.
	- Drop-down menu option for expanding/collapsing all subtrees when right-clicking on a tree node.
	- Query box is auto-selected when tree is opened.
	- `Ctrl+Enter` while query box is selected submits the query.
	- `Enter` while any button selected is equivalent to clicking it.
	- `Enter` while tree is selected toggles the selected node between expanded/collapsed.
	- `Escape` key takes focus from the tree back to the text editor (resolves Issue #11).

CHANGED
1. Minimizing the tree view closes it completely.
@vinsworldcom
Copy link
Author

Seems to work now, although there is a system 'bell' when tabbing from tree view to the "Current Path" button.

@vinsworldcom vinsworldcom reopened this Sep 26, 2022
molsonkiko added a commit that referenced this issue Mar 23, 2023
fix issues #10 and #11 (system bell on tree view)
Address (hopefully) issue #12 (text cutoff)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants