Skip to content

Commit

Permalink
Resize icons to work on issue #53
Browse files Browse the repository at this point in the history
I think that the issue where icons disappear going from light to dark is fixed.
I've tested both 32bit and 64bit on "standard icons: small", "Fluent UI: small", and "Fluent UI: large", and it appears to *mostly* work fine going from both light to dark and dark to light.
Sometimes the icons still disappear. I cannot discern a pattern in these disappearances.
  • Loading branch information
molsonkiko committed Dec 24, 2024
1 parent 4d85e55 commit 0cb8dc8
Show file tree
Hide file tree
Showing 15 changed files with 22 additions and 16 deletions.
10 changes: 8 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,20 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- In 6.1.1.18, there is no longer a global shared JsonParser, which was the main potential source of race conditions.
- Fix issue where pretty-printing or compressing causes tree view position tracking to be out of sync with the document until a query is issued or the `Refresh` button is hit.
- Improve Alt-key accelerators *in forms*. They don't seem to work right for some reason.
- Fix problem where icons disappear when going from light mode to dark mode (until Notepad++ is closed; does not persist after restart)
- this problem only seems to appear after the user has opened a docking form, and maybe not even every time
- *Completely* Fix problem where icons disappear when going from light mode to dark mode (until Notepad++ is closed; does not persist after restart)
- this problem rarely surfaces, but it doesn't seem to be completely addressed
- issue with treeview closing when a file with a treeview is moved from one view to another
- `loop()` function used in `s_sub` callbacks is not thread-safe. *This doesn't matter right now* because RemesPath is single-threaded, but it could matter in the future.
- GrepperForm loses its JSON permanently when the buffer associated with its treeview is deleted.
- Since v7.0, holding down `Enter` in a multiline textbox (like the [tree viewer query box](/docs/README.md#remespath)) only adds one newline when the key is lifted.
- Maybe use pre-7.1 (dictionary-based rather than indicator-based) [selection remembering](/docs/README.md#working-with-selections) for Notepad++ 8.5.5 and earlier? Indicators are risky with those older NPP's because of the lack of `NPPM_ALLOCATEINDICATOR`.

## [8.4.0] - (UNRELEASED) YYYY-MM-DD

### Fixed

1. Mostly fix bug where icons would disappear when going from light to dark mode. As a side effect, the icons when using "standard icons: small" are smaller, but the icons under other conditions are larger.

## [8.3.1] - 2024-12-22

### Fixed
Expand Down
4 changes: 2 additions & 2 deletions JsonToolsNppPlugin/Properties/AssemblyInfo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -28,5 +28,5 @@
// Build Number
// Revision
//
[assembly: AssemblyVersion("8.3.1.0")]
[assembly: AssemblyFileVersion("8.3.1.0")]
[assembly: AssemblyVersion("8.3.1.1")]
[assembly: AssemblyFileVersion("8.3.1.1")]
Binary file modified JsonToolsNppPlugin/Resources/json compress toolbar bmp.bmp
Binary file not shown.
Binary file modified JsonToolsNppPlugin/Resources/json compress toolbar darkmode.ico
Binary file not shown.
Binary file modified JsonToolsNppPlugin/Resources/json compress toolbar.ico
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified JsonToolsNppPlugin/Resources/json path to position toolbar.ico
Binary file not shown.
Binary file modified JsonToolsNppPlugin/Resources/json pretty print toolbar bmp.bmp
Binary file not shown.
Binary file not shown.
Binary file modified JsonToolsNppPlugin/Resources/json pretty print toolbar.ico
Binary file not shown.
Binary file modified JsonToolsNppPlugin/Resources/json tree toolbar bmp.bmp
Binary file not shown.
Binary file modified JsonToolsNppPlugin/Resources/json tree toolbar darkmode.ico
Binary file not shown.
Binary file modified JsonToolsNppPlugin/Resources/json tree toolbar.ico
Binary file not shown.
24 changes: 12 additions & 12 deletions JsonToolsNppPlugin/Resources/json-tools icons.bat
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,19 @@ magick "string type icon.png" "string type icon.ico"
magick "null type icon.png" "null type icon.ico"

: add toolbar bitmaps
magick "json pretty print icon.png" -resize 20x20 "json pretty print toolbar bmp.bmp"
magick "json compress icon.png" -resize 20x20 "json compress toolbar bmp.bmp"
magick "json path to position icon.png" -resize 20x20 "json path to position toolbar bmp.bmp"
magick "json tree icon.png" -resize 20x20 "json tree toolbar bmp.bmp"
magick "json pretty print icon.png" -resize 16x16! "json pretty print toolbar bmp.bmp"
magick "json compress icon.png" -resize 16x16! "json compress toolbar bmp.bmp"
magick "json path to position icon.png" -resize 16x16! "json path to position toolbar bmp.bmp"
magick "json tree icon.png" -resize 16x16! "json tree toolbar bmp.bmp"

: add toolbar icons
magick "json pretty print icon.png" -resize 20x20 "json pretty print toolbar.ico"
magick "json compress icon.png" -resize 20x20 "json compress toolbar.ico"
magick "json path to position icon.png" -resize 20x20 "json path to position toolbar.ico"
magick "json tree icon.png" -resize 20x20 "json tree toolbar.ico"
magick "json pretty print icon.png" -resize 32x32! "json pretty print toolbar.ico"
magick "json compress icon.png" -resize 32x32! "json compress toolbar.ico"
magick "json path to position icon.png" -resize 32x32! "json path to position toolbar.ico"
magick "json tree icon.png" -resize 32x32! "json tree toolbar.ico"

: add darkmode icons
magick "json pretty print icon darkmode.png" -resize 20x20 "json pretty print toolbar darkmode.ico"
magick "json compress icon darkmode.png" -resize 20x20 "json compress toolbar darkmode.ico"
magick "json path to position icon darkmode.png" -resize 20x20 "json path to position toolbar darkmode.ico"
magick "json tree toolbar darkmode.png" -resize 20x20 "json tree toolbar darkmode.ico"
magick "json pretty print icon darkmode.png" -resize 32x32! "json pretty print toolbar darkmode.ico"
magick "json compress icon darkmode.png" -resize 32x32! "json compress toolbar darkmode.ico"
magick "json path to position icon darkmode.png" -resize 32x32! "json path to position toolbar darkmode.ico"
magick "json tree toolbar darkmode.png" -resize 32x32! "json tree toolbar darkmode.ico"

0 comments on commit 0cb8dc8

Please sign in to comment.