Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: molgenis theme title color #4662

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

connoratrug
Copy link
Contributor

What are the main changes you did

fix: molgenis theme title color

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

Copy link
Contributor

@BrendaHijmans BrendaHijmans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In catalogue looks like color settings are back to normal.

@@ -54,7 +54,7 @@
--text-color-sub-menu-hover: var(--color-blue-700);
--text-color-breadcrumb-arrow: var(--color-white);
--text-color-breadcrumb: var(--color-blue-50);
--text-color-title: var(--color-gray-900);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason this was changed to gray?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the bases theme changed form 'molgenis' to light

@connoratrug connoratrug merged commit d2e96a5 into master Feb 3, 2025
7 checks passed
@connoratrug connoratrug deleted the fix/molgenis-theme-title-color branch February 3, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants