Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose the filled out form values ( and errors) #4612

Merged
merged 1 commit into from
Jan 20, 2025
Merged

feat: expose the filled out form values ( and errors) #4612

merged 1 commit into from
Jan 20, 2025

Conversation

connoratrug
Copy link
Contributor

What are the main changes you did

  • emit the field values and error
  • show values and errors in story
  • test the values ( note delay for hydration issue when testing locally)

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@connoratrug connoratrug requested a review from chinook25 January 17, 2025 14:43
@connoratrug connoratrug mentioned this pull request Jan 17, 2025
Closed
3 tasks
@connoratrug connoratrug merged commit 7659fa8 into master Jan 20, 2025
7 checks passed
@connoratrug connoratrug deleted the feat/expose-form-values branch January 20, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chinook25 chinook25 chinook25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connoratrug @chinook25