feat(tailwind): setup tailwind themes #4600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mswertz
approved these changes
Jan 13, 2025
i does not work ( :D yet ) |
|
|
||
| --opacity-background-gradient: 100; | ||
|
|
||
| --backgroud-color-button-primary: var(--color-yellow-500); |
There was a problem hiding this comment.
In the InputRef PR, I've fixed this typo: backgroud-* in the main.css and tailwind config files.
| --border-color-button-disabled: var(--color-gray.100); | ||
| --border-color-button-disabled-hover: var(--color-gray.100); | ||
| --border-color-menu-active: var(--color-orange-500); | ||
| --border-color-search-button: #CCCCCC; |
There was a problem hiding this comment.
Should these colors be variables? We might need to expand the palettes to account for new colors.
There was a problem hiding this comment.
yes but not part of this pr
hslh
approved these changes
Jan 15, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the main changes you did
Support for multiple themes
styling using tailwind, apply theme using data-theme attr
follow design
light, dark, molgenis, umcg ( aumc = beta )
add config for light
add config for dark
replace 'hard coded' styles with theme styles
add 1 or more demo page to show/evaluate styles
How to test
Checklist