Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(catalogue): add UMCG template loader #4466

Merged
merged 14 commits into from
Nov 21, 2024
Merged

fix(catalogue): add UMCG template loader #4466

merged 14 commits into from
Nov 21, 2024

Conversation

BrendaHijmans
Copy link
Contributor

@BrendaHijmans BrendaHijmans commented Nov 8, 2024 •
edited
Loading

What are the main changes you did:

  • edits yaml file
  • add template loader

can someone add a test?

how to test:

  • explain here what to do to test this (or point to unit tests)

todo:

  • added/updated tests

@BrendaHijmans BrendaHijmans requested a review from YpeZ November 14, 2024 08:03
YpeZ
YpeZ approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@YpeZ YpeZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the name/description of the YAML file.

Checked the creation of a staging area on the preview, which works as expected.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@BrendaHijmans BrendaHijmans merged commit 7e49563 into master Nov 21, 2024
6 checks passed
@BrendaHijmans BrendaHijmans deleted the fix/umcg-template-loader branch November 21, 2024 09:27
davidruvolo51 pushed a commit that referenced this pull request Nov 26, 2024
@BrendaHijmans @davidruvolo51
fix(catalogue): add UMCG template loader (#4466)
63fdd73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YpeZ YpeZ YpeZ approved these changes

@mswertz mswertz Awaiting requested review from mswertz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrendaHijmans @YpeZ