fix(catalogue): resource details page not rendering when resource.peopleInvolved is empty

[mswertz]

Before:

• FAIL https://emx2.dev.molgenis.org/catalogue-demo/ssr-catalogue/testNetwork1/networks/testNetwork1

After:

• SUCCESS https://preview-emx2-pr-4347.dev.molgenis.org/catalogue-demo/ssr-catalogue/testNetwork1/networks/testNetwork1

[connoratrug]

if peopleInvolved is falsy, the value of the contributors becomes undefined , whereas i would expect an empty list.

also is contributors now 'peopleInvolvedSoretedByRoleAndName' ?

[mswertz]

why would you expect empty list? I mean, the list should not be there if there are no values? See line 599 where the content block is conditional. That could instead be conditional on length > 0 is that better?

I will indeed rename the contributors to be more meaningful as you suggest

(and we should discuss with catalogue team if it should be 'contributors' or 'people involved'

[connoratrug]

looking at sort code i still see several potential null pointer issues (minimumOrderOfRolesB = b.role?.length , minimumOrderOfRolesB is undefined if roles is undefined, this later may result in number - undefined )( did a llm write this ?) but this pr fixes the relevant case in the catalogue
const contributors = computed(() => resource.value.peopleInvolved?.sort((a, b) => { const minimumOrderOfRolesA = a.role?.length ? Math.min(...a.role?.map((role) => role.order ?? Infinity)) : Infinity; const minimumOrderOfRolesB = b.role?.length ? Math.min(...b.role?.map((role) => role.order ?? Infinity)) : Infinity; if (minimumOrderOfRolesA !== minimumOrderOfRolesB) { return minimumOrderOfRolesA - minimumOrderOfRolesB; } else if (a.lastName !== b.lastName) { return a.lastName.localeCompare(b.lastName); } else { return a.firstName.localeCompare(b.firstName); } }) );

[connoratrug]

now that its renamed its easer to follow , a see thats it to separate thing, a sortByRoleAndName function and getter from the query response ,

const peopleInvolved = resource?.peopleInvolved.length ? resource.peopleInvolved.sort(byRoleAndName) : [ ]

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud