Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Year 0 harmonisation details check mark is displayed while there is no data for this mapping #4428

Closed
BrendaHijmans opened this issue Nov 1, 2024 · 3 comments · Fixed by #4550
Labels
bug Something isn't working

Comments

@BrendaHijmans
Copy link
Contributor

BrendaHijmans commented Nov 1, 2024

What version of EMX2 are you using (see footer)
v11.25.2

Describe the bug
Year 0 harmonisation details are not displayed in variable harmonisations detail view.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://data-catalogue-acc.molgeniscloud.org/testCatalogue/ssr-catalogue/testNetwork1/
  2. Click on Variables
  3. Click on testVarRepeats_
  4. See in harmonisation matrix ('Harmonisation status per data source') that Year 0 to Year 10 are present (so 11 variables) and that testCohort 1 has harmonised Year 0 to Year 10
  5. Go to the underlying data: https://data-catalogue-acc.molgeniscloud.org/testCatalogue/tables/#/VariableMappings
  6. Search for testVarRepeats.
  7. See that there is no mapping to year 0 for testCohort1 for testVarRepeats
@BrendaHijmans BrendaHijmans added the bug Something isn't working label Nov 1, 2024
@BrendaHijmans BrendaHijmans changed the title Year 0 harmonisation details are not displayed in variable harmonisations detail view Year 0 harmonisation details (syntax etc) are not displayed in variable harmonisations detail view Nov 1, 2024
@connoratrug connoratrug self-assigned this Nov 13, 2024
@hslh
Copy link
Contributor

hslh commented Nov 13, 2024

Okay, we'll have to fix this in test data then at some point.

@hslh hslh reopened this Nov 13, 2024
@hslh hslh assigned hslh and unassigned connoratrug Nov 14, 2024
@hslh hslh assigned hslh, BrendaHijmans and connoratrug and unassigned hslh and connoratrug Nov 27, 2024
@BrendaHijmans
Copy link
Contributor Author

Hmm, then the bug is the other way around: the check mark for testCohort1 for Year 0 should not be shown in the harmonisation matrix
image

@connoratrug connoratrug removed their assignment Nov 27, 2024
@BrendaHijmans BrendaHijmans changed the title Year 0 harmonisation details (syntax etc) are not displayed in variable harmonisations detail view Year 0 harmonisation details check mark is displayed while there is no data for this mapping Nov 27, 2024
@BrendaHijmans BrendaHijmans removed their assignment Nov 28, 2024
mswertz added a commit that referenced this issue Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants