Fix wouter link to prevent crash without href/to #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #485 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 1 1
=========================================
Hits 1 1 ☔ View full report in Codecov by Sentry. |
molefrog
reviewed
Aug 28, 2024
packages/wouter/src/index.js
Outdated
| @@ -265,7 +265,9 @@ export const Link = forwardRef((props, ref) => { | |||
|
|
|||
| // handle nested routers and absolute paths | |||
| const href = router.hrefs( | |||
| targetPath[0] === "~" ? targetPath.slice(1) : router.base + targetPath, | |||
| (targetPath ?? "")[0] === "~" | |||
There was a problem hiding this comment.
Thank you for the PR!
As a suggestion, this could also be done by providing the default value for to when destructuring props:
const {
to = "",
href: targetPath = to,(above in this file)
There was a problem hiding this comment.
Yes that's better, thanks! Will change it to your suggestion
molefrog
approved these changes
Aug 28, 2024
|
Released in v3.3.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Link />components are mainly used together withhrefand/ortoattributes, but there are cases where you'd only rely on theonClickproperty to navigate. In these cases, wouter crashes when it tries to check for absolute paths.This PR fixes it by making sure the absolute path test is pointed against a string and not undefined.
(Context: I noticed this issue when using wouter together with plasmic. Plasmic allows to specify the link component being used to take advantage of client-side navigation. In some cases though you'd use the interactions (which is triggered inside
onClick) to navigate in response to e.g. an API call. In these cases, wouter crashed).