Fix a wrong (oversized) initial capacity for the internal hash map #83
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I misunderstood what the initial capacity would do for
cht::SegmentedHashMap
. I thought it was the initial capacity of the entire hash map, but the cht author meant it was the initial capacity of each segment in the hash map. Since Moka usesSegmentedHashMap
with currently hard-coded number of segments64
, setting the initial capacity using Moka'sCacheBuilder
results the hash map 64 times bigger than desired.This PR changes the initial capacity of
moka::cht::SegmentedHashMap
to be the capacity of the entire hash map.