Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect overflow when computing expiration (part 2) #58

Merged
merged 6 commits into from
Dec 19, 2021
Merged

Protect overflow when computing expiration (part 2) #58

merged 6 commits into from
Dec 19, 2021
+151 −80

Conversation

tatsuya6502
Copy link
Member

This is a follow up PR for #56.

  • Update CacheBuilder::build_with_hasher method to do the same duration checks to build methods.
  • Update the API doc to explain panics.
  • Not related to overflow checks but also tweaked the contents of the README.

@tatsuya6502 tatsuya6502 added this to the v0.6.2 milestone Dec 19, 2021
tatsuya6502
tatsuya6502 commented Dec 19, 2021
View reviewed changes
Copy link
Member Author

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging.

@tatsuya6502 tatsuya6502 merged commit 3d92834 into master Dec 19, 2021
@tatsuya6502 tatsuya6502 deleted the prevent-ttl-overflow-take2 branch December 19, 2021 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.2
Development

Successfully merging this pull request may close these issues.
1 participant
@tatsuya6502