Handle panic in the init closure/future of get_or_insert_with and get_or_try_insert_with
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update `future::Cache` to handle panic in the `init` future of `get_or_insert_with` and `get_or_try_insert_with`. - Add `futures` crate as optional for `future` feature.
Add sync and time features to Tokio in the dev-dependency.
Tweak the code from previous commits under `future` module.
Update `sync::Cache` to handle panic in the `init` closure of `get_or_insert_with` and `get_or_try_insert_with`.
tatsuya6502
commented
Sep 18, 2021
Add the max retries, just for safty.
|
Thank you for fixing this quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue reported by #43.
Changes
When the user-provided
initfuture/closure forget_or_insert_withorget_or_try_insert_withmethod has panicked, it will catch the panic, remove the waiter for the key, and resume the panic. It also restarts other in-progress (actually blocked) method calls on the same key.futurescrate for Moka'sfuturefeature.future::Cacheto handle panic in theinitfuture ofget_or_insert_withandget_or_try_insert_with.sync::Cacheto handle panic in theinitfuture ofget_or_insert_withandget_or_try_insert_with.Fixes #43