Better async waiting for when the write op channel is full #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the async
may_yieldfunction introduced atv0.12.0-beta.1with a more efficient implementation. It uses anasync_lock::RwLockbetween a user async task, that is currently running internaldo_run_pending_tasks, and other user async tasks.This will be more CPU efficient than
may_yieldbecause it makes some of the user async tasks to wait for reader locks, rather than keeping spinning, so that the async runtime scheduler can run other async tasks if there are any.This PR also bumps the version to
v0.12.0-beta.3.