Fix occasional panic in FrequencySketch
in debug build
#272
+110
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267.
Fixes #113.
This PR prevents an internal
index_of
method ofFrequencySketch
from panicking by arithmetic overflow.Changes
u64
addition (+
) operator inFrequencySketch::index_of
method withwrapping_add
method.index_of
method.+
operator will behave the same towrapping _add
method in release build (where overflow checks are disabled).FrequencySketch
(not only forindex_of
method but also other methods).Verification
cargo kani
before fixing the issue, and arithmetic overflow was detected.cargo kani
after fixing, and no issue was detected.