Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

future::Cache's .blocking().invalidate(key) should trigger the eviction listener #246

Merged
merged 2 commits into from
Mar 25, 2023
Merged

future::Cache's .blocking().invalidate(key) should trigger the eviction listener #246

merged 2 commits into from
Mar 25, 2023

Conversation

tatsuya6502
Copy link
Member

@tatsuya6502 tatsuya6502 commented Mar 25, 2023 •
edited
Loading

Fixes #242.

Changes

  • Fix an internal do_blocking_invalidate method to notify the eviction listener when an entry is evicted.
  • Update a test to verify that the eviction listener is notified when an entry is evicted by .blocking().invalidate(key).

Verification Methods

@tatsuya6502
future::Cache's .blocking().invalidate(key) should trigger
83ce745 
the eviction listener

- Fix an internal `do_blocking_invalidate` method to notify the eviction listener
  when an entry is evicted.
- Update a test to verify that the eviction listener is notified when an entry is
  evicted by `.blocking().invalidate(key)`.
@tatsuya6502 tatsuya6502 self-assigned this Mar 25, 2023
@tatsuya6502 tatsuya6502 added the bug Something isn't working label Mar 25, 2023
@tatsuya6502 tatsuya6502 added this to the v0.10.1 milestone Mar 25, 2023
tatsuya6502
tatsuya6502 commented Mar 25, 2023
View reviewed changes
Copy link
Member Author

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging.

@tatsuya6502 tatsuya6502 added this pull request to the merge queue Mar 25, 2023
Merged via the queue into master with commit 05fdf06 Mar 25, 2023
@tatsuya6502 tatsuya6502 deleted the blocking-invalidate-should-trigger-listener branch March 25, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tatsuya6502 tatsuya6502

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.10.1
Development

Successfully merging this pull request may close these issues.

.blocking().invalidate(key) doesn't trigger eviction listener
1 participant
@tatsuya6502