Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use all remote repositories for artifacts resolving #226

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

slawekjaranowski
Copy link
Member

we should use default remote repositories and repositories defined in project

Fix #225

Copy link

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jglick
Copy link
Contributor

jglick commented Jul 21, 2022

Did either of those approving verify that this change does in fact solve the reported problem? (Did not occur in my configuration to begin with.)

@basil
Copy link

basil commented Jul 21, 2022

Did either of those approving verify that this change does in fact solve the reported problem? (Did not occur in my configuration to begin with.)

You must not trust me.

we should use default remote repositories and repositories defined in project

Fix #225
@MarkEWaite
Copy link

Did either of those approving verify that this change does in fact solve the reported problem? (Did not occur in my configuration to begin with.)

I did not. I'm happy to attempt that verification if it helps. As far as I can tell, the duplication instructions in the issue report should be repeatable. They are:

$ rm -rf implied-labels-plugin
$ git clone https://github.com/jenkinsci/implied-labels-plugin.git
$ cd implied-labels-plugin
$ echo '<settings></settings>' > settings.xml
$ mvn validate

@slawekjaranowski
Copy link
Member Author

I have tested my change with implied-labels-plugin project according to instructions from issue.

I override version for test in pom, like:

  <build>
    <plugins>
        <plugin>
          <artifactId>maven-enforcer-plugin</artifactId>
          <dependencies>
            <dependency>
              <groupId>org.codehaus.mojo</groupId>
              <artifactId>extra-enforcer-rules</artifactId>
              <version>1.6.1-SNAPSHOT</version>
            </dependency>
          </dependencies>
        </plugin>
      </plugins>
  </build>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.6.0 warns about missing dependencies when previous versions did not
4 participants