Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

«Enforce Bytecode Version» rule: Introduce Java 18 support #200

Closed
svbrunov opened this issue May 11, 2022 · 2 comments · Fixed by #214
Closed

«Enforce Bytecode Version» rule: Introduce Java 18 support #200

svbrunov opened this issue May 11, 2022 · 2 comments · Fixed by #214
Labels
EnforceBytecodeVersion enhancement good first issue Indicates a good issue for first-time contributors

Comments

@svbrunov
Copy link

Dear maintainers,

The «Enforce Bytecode Version» rule does not support Java 18.

Let's consider the following execution configuration:

<execution>
    <id>enforce-bytecode-version</id>
    <goals>
        <goal>enforce</goal>
    </goals>
    <configuration>
        <rules>
            <enforceBytecodeVersion>
                <maxJdkVersion>18</maxJdkVersion>
            </enforceBytecodeVersion>
        </rules>
    </configuration>
</execution>

The org.apache.maven.plugins:maven-enforcer-plugin:3.0.0:enforce goal fails with the following error message:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.0.0:enforce (enforce-bytecode-version) on project avito-data: Execution enforce-bytecode-version of goal org.apache.maven.plugins:maven-enforcer-plugin:3.0.0:enforce failed: Unknown JDK version given. Should be something like "1.7", "8", "11", "12", "13", "14", "15", "16", "17" -> [Help 1]

Could you please introduce the Java 18 support for the «Enforce Bytecode Version» rule and afterwards release the new version of the plugin?

Best regards,
Sergey Vyacheslavovich Brunov.

@slawekjaranowski slawekjaranowski added enhancement good first issue Indicates a good issue for first-time contributors labels Jun 8, 2022
@slawekjaranowski slawekjaranowski linked a pull request Jun 26, 2022 that will close this issue
@svbrunov
Copy link
Author

Dear Slawomir Jaranowski (@slawekjaranowski),

Thank you for the update!

Could you please release the updated version?

Best regards,
Sergey Vyacheslavovich Brunov.

@slawekjaranowski
Copy link
Member

I hope I will release in next two weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EnforceBytecodeVersion enhancement good first issue Indicates a good issue for first-time contributors
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants