feat(mojaloop/#3445): nodejs upgrade #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oderayi
requested changes
Dec 18, 2023
There was a problem hiding this comment.
Looking good!
- A question regrading logs management.
- This line need to change.
Line 21 in dc53add
- Also, do a snapshot release to validate the release pipeline.
Comment on lines
+36
to
+39
| # Create empty log file & link stdout to the application log file | ||
| RUN mkdir ./logs && touch ./logs/combined.log | ||
| # Links combined to stdout | ||
| RUN ln -sf /dev/stdout ./logs/combined.log |
There was a problem hiding this comment.
Not sure, it's added into every Dockerfile already, I'll investigate.
There was a problem hiding this comment.
By linking the standard output to the application log file, any output written to stdout by the application will be redirected and appended to the "combined.log" file. This allows us to access and monitor the application's log output.
There was a problem hiding this comment.
Ok, thank you for the clarification.
The central-service-logger also defaults to writing to that file when using the file transport for logging:
https://github.com/mojaloop/central-services-logger/blob/966826cab74713a2ba743fe1b89eb200acfb7c68/config/default.json#L10
oderayi
approved these changes
Dec 19, 2023
This was referenced Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.