Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(mojaloop/#3443): nodejs upgrade #54

Merged
merged 9 commits into from
Sep 14, 2023
Merged

chore(mojaloop/#3443): nodejs upgrade #54

merged 9 commits into from
Sep 14, 2023

Conversation

oderayi
Copy link
Contributor

@oderayi oderayi commented Sep 13, 2023 •
edited
Loading

chore(mojaloop/#3443): nodejs upgrade - mojaloop/project#3443

  • Upgraded NodeJS from v16 to v18 LTS
  • Updated CI config to use NodeJS latest LTS version
  • Updated CI config to display runtime versions for each job
  • Upgraded NPM dependencies
  • Fixed CI bugs caused by the NodeJS upgrade
  • Updated CI pipeline use NVM to select node version from .nvmrc file
  • Upgraded circleci orbs
  • Migrated master branch to main
  • Added .versionrc

@oderayi oderayi marked this pull request as ready for review September 13, 2023 12:42
mdebarros
mdebarros reviewed Sep 13, 2023
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versionrc?

@mdebarros
Copy link
Member

@oderayi I assume you will update this PR with the latest event-sdk release?

@oderayi oderayi requested a review from mdebarros September 14, 2023 09:02
mdebarros
mdebarros approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@oderayi oderayi merged commit 03994b7 into mojaloop:main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdebarros mdebarros mdebarros approved these changes

@elnyry-sam-k elnyry-sam-k Awaiting requested review from elnyry-sam-k elnyry-sam-k is a code owner

@vijayg10 vijayg10 Awaiting requested review from vijayg10 vijayg10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oderayi @mdebarros