FIX-#3736: Don't use a 2-d array to set a categorical column. #3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lumn. Signed-off-by: mvashishtha <mahesh@ponder.io>
Codecov Report
@@ Coverage Diff @@
## master #3777 +/- ##
==========================================
+ Coverage 80.52% 86.49% +5.96%
==========================================
Files 197 197
Lines 16414 16660 +246
==========================================
+ Hits 13218 14410 +1192
+ Misses 3196 2250 -946
Continue to review full report at Codecov.
|
|
|
vnlitvinov
reviewed
Dec 6, 2021
I think so. In contrast to the first snippet here, this seems to work on both Pandas and Modin 0.12: import modin.pandas as pd
from numpy import array
df = pd.DataFrame({"status": ["a", "b", "c"]})
df.loc[:1, "status"] = "a" |
Co-authored-by: Vasily Litvinov <vasilij.n.litvinov@intel.com>
There is a fix PR out for pandas-dev/pandas#44703, but we decided at the meeting on December 3 to not wait until that PR is released. |
Signed-off-by: mvashishtha <mahesh@ponder.io>
|
vnlitvinov
approved these changes
Dec 7, 2021
devin-petersohn
approved these changes
Dec 7, 2021
YarShev
reviewed
Dec 8, 2021
| def test_feature_names(feature_names): | ||
| data = np.random.randn(100, 5) | ||
| label = np.array([0, 1] * 50) | ||
| def test_feature_names(): |
There was a problem hiding this comment.
@mvashishtha, I wonder why this PR contains changes in this file, though it shouldn't, because the changes were preliminary merged into master as part of another PR.
There was a problem hiding this comment.
Yes, I don't understand. Git blame correctly points to #3770 for these lines.
devin-petersohn
pushed a commit
that referenced
this pull request
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mvashishtha mahesh@ponder.io
What do these changes do?
Work around pandas-dev/pandas#44703 by not converting a categorical scalar to a 2-d array to set a categorical column.
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/developer/architecture.rstis up-to-date