Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dmatrix testing failures in CI #3767

Closed
prutskov opened this issue Dec 2, 2021 · 0 comments · Fixed by #3770
Closed

Fix dmatrix testing failures in CI #3767

prutskov opened this issue Dec 2, 2021 · 0 comments · Fixed by #3770
Assignees
@prutskov
Labels
CI Flaky Test

Comments

@prutskov
Copy link
Contributor

prutskov commented Dec 2, 2021

Starting from 4d7f6d4 test_dmatrix sporadically fails in CI testing. Possible reason is in strict check of equality between XGBoost/Modin XGBoost result:

modin/modin/experimental/xgboost/test/test_dmatrix.py

Line 129 in cc96f5d

assert preds.all() == md_preds.all()

@prutskov prutskov self-assigned this Dec 2, 2021
@prutskov prutskov added the CI label Dec 2, 2021
@prutskov prutskov mentioned this issue Dec 2, 2021
Draft
7 tasks
@prutskov prutskov mentioned this issue Dec 2, 2021
Merged
7 tasks
prutskov added a commit to prutskov/modin that referenced this issue Dec 3, 2021
@prutskov
FIX-modin-project#3767: Fix tests for Modin XGB Dmatrix
706083e 
Signed-off-by: Alexey Prutskov <alexey.prutskov@intel.com>
YarShev pushed a commit that referenced this issue Dec 3, 2021
@prutskov
FIX-#3767: Fix tests for Modin XGB Dmatrix (#3770)
a4ed727 
Signed-off-by: Alexey Prutskov <alexey.prutskov@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prutskov prutskov

Labels
CI Flaky Test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX-#3767: Fix tests for Modin XGB Dmatrix prutskov/modin
2 participants
@mvashishtha @prutskov