Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HeadFile): fix dis reversal, expand tests #2247

Merged
merged 5 commits into from
Jun 25, 2024

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Jun 21, 2024

Fix the write logic for head file reversal to properly write each layer. Add a test for each discretization type. Fix in-place reverse by writing to a temp file first then renaming. Improve docstrings.

@cneyens could you check if this resolves #2246 on your end?

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.7%. Comparing base (9dd66c7) to head (4341c30).

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2247     +/-   ##
=========================================
+ Coverage     73.6%   75.7%   +2.0%     
=========================================
  Files          294     294             
  Lines        59029   58909    -120     
=========================================
+ Hits         43476   44624   +1148     
+ Misses       15553   14285   -1268     
Files Coverage Δ
flopy/utils/binaryfile.py 86.4% <98.2%> (+4.3%) ⬆️

... and 142 files with indirect coverage changes

@wpbonelli wpbonelli marked this pull request as ready for review June 24, 2024 17:30
@wpbonelli
Copy link
Member Author

I did some testing on example models, this seems to work OK for structured and unstructured grids. Feel free to reopen if you still see issues @cneyens.

@wpbonelli wpbonelli merged commit 9db562a into modflowpy:develop Jun 25, 2024
25 checks passed
@wpbonelli wpbonelli deleted the 2246 branch June 25, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: reverse Headfile fails for structured grids
2 participants