Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(expired deprecation): raise AttributeError with to_shapefile #2200

Merged

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented May 29, 2024

This PR changes deprecated .to_shapefile() functions to raise AttributeError with a helpful message.

These are the affected functions:

While these functions have been deprecated since 3.2.4 released in 2016 (changelog), they were never documented as such. Thus a helpful exception message and cross-referenced docstring is used instead of removing these functions.


Xref to #1884 where a similar approach was used.

@mwtoews mwtoews force-pushed the to_shapefile_raises_attributeerror branch from 9496361 to e1909f0 Compare May 29, 2024 00:42
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.8%. Comparing base (a49b613) to head (483c493).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2200     +/-   ##
=========================================
+ Coverage     66.2%   69.8%   +3.5%     
=========================================
  Files          294     294             
  Lines        58856   59012    +156     
=========================================
+ Hits         39009   41224   +2215     
+ Misses       19847   17788   -2059     
Files Coverage Δ
flopy/mbase.py 69.9% <100.0%> (+0.3%) ⬆️
flopy/pakbase.py 81.9% <100.0%> (+1.0%) ⬆️
flopy/utils/util_list.py 73.9% <100.0%> (+1.1%) ⬆️

... and 208 files with indirect coverage changes

@mwtoews mwtoews force-pushed the to_shapefile_raises_attributeerror branch from e1909f0 to 483c493 Compare May 29, 2024 21:53
Copy link
Member

@wpbonelli wpbonelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mwtoews

@wpbonelli wpbonelli merged commit 31955a7 into modflowpy:develop May 30, 2024
24 checks passed
@mwtoews mwtoews deleted the to_shapefile_raises_attributeerror branch May 30, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants