refactor(expired deprecation): raise AttributeError with to_shapefile #2200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes deprecated
.to_shapefile()
functions to raise AttributeError with a helpful message.These are the affected functions:
flopy.utils.util_list.MfList.to_shapefile
flopy.pakbase.Package.to_shapefile
flopy.mbase.BaseModel.to_shapefile
While these functions have been deprecated since 3.2.4 released in 2016 (changelog), they were never documented as such. Thus a helpful exception message and cross-referenced docstring is used instead of removing these functions.
Xref to #1884 where a similar approach was used.