Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grb): update binary grid file reader for new grid types #2157

Merged
merged 4 commits into from
Apr 17, 2024

Conversation

christianlangevin
Copy link

No description provided.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 71.1%. Comparing base (f4a4274) to head (6388d25).
Report is 2 commits behind head on develop.

❗ Current head 6388d25 differs from pull request most recent head baa6ec6. Consider uploading reports for the commit baa6ec6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2157     +/-   ##
=========================================
- Coverage     72.9%   71.1%   -1.9%     
=========================================
  Files          260     260             
  Lines        58119   58132     +13     
=========================================
- Hits         42398   41356   -1042     
- Misses       15721   16776   +1055     
Files Coverage Δ
flopy/mf6/utils/binarygrid_util.py 89.9% <35.7%> (-2.5%) ⬇️

... and 64 files with indirect coverage changes

@christianlangevin christianlangevin merged commit 30e0349 into modflowpy:develop Apr 17, 2024
24 checks passed
@christianlangevin christianlangevin deleted the fix-grb branch April 23, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant