Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(get-modflow): support windows parallel nightly build #2128

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Mar 22, 2024

*maybe consider generalizing in future — instead of hardcoding supported asset names, dynamically discover them from the release info? in particular, if assets are expected to change as more mf6 variants (architecture, parallel/netcdf, etc) are included

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.1%. Comparing base (b142b08) to head (ffb18eb).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2128     +/-   ##
=========================================
+ Coverage     71.3%   73.1%   +1.7%     
=========================================
  Files          259     259             
  Lines        59511   59526     +15     
=========================================
+ Hits         42479   43531   +1052     
+ Misses       17032   15995   -1037     
Files Coverage Δ
flopy/utils/get_modflow.py 64.2% <100.0%> (-0.1%) ⬇️

... and 59 files with indirect coverage changes

@wpbonelli wpbonelli marked this pull request as ready for review March 22, 2024 17:33
@wpbonelli wpbonelli merged commit 43e5178 into modflowpy:develop Mar 22, 2024
24 checks passed
@wpbonelli wpbonelli deleted the win64par branch March 22, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant