Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(get_cell_vertices): raise helpful messages, improve docs, add tests #2125

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Mar 17, 2024

This is a general refactor of get_cell_vertices() to raise helpful exception messages, improve the docstrings, and add some missing tests.

@mwtoews mwtoews force-pushed the refactor-get_cell_vertices branch from 0c7c6e2 to df85678 Compare March 17, 2024 21:23
Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.3%. Comparing base (b142b08) to head (df85678).

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #2125   +/-   ##
=======================================
  Coverage     71.3%   71.3%           
=======================================
  Files          259     259           
  Lines        59511   59520    +9     
=======================================
+ Hits         42479   42492   +13     
+ Misses       17032   17028    -4     
Files Coverage Δ
flopy/discretization/structuredgrid.py 47.5% <100.0%> (+0.9%) ⬆️

... and 1 file with indirect coverage changes

@wpbonelli wpbonelli merged commit 00b3d1c into modflowpy:develop Mar 18, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants