feat: add static methods to read gridgen quadtreegrid files #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2061 +/- ##
=========================================
- Coverage 73.0% 73.0% -0.1%
=========================================
Files 259 259
Lines 59298 59260 -38
=========================================
- Hits 43305 43271 -34
+ Misses 15993 15989 -4
|
langevin-usgs
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Hey @martinvonk, nice job with this, and making it through all the flopy checks. Looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2059.
Previously, gridgen files could not be read without an instance of the Gridgen class. This PR adds static methods to the gridgen class that read the gridgen files.