Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(generate_classes): deprecate branch for ref, introduce repo, test commit hashes #1907

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Aug 5, 2023

  • add repo parameter, in case e.g. a fork is named differently
  • add ref parameter, deprecate branch
    • should be generically named since supports hashes, branch names, tags
    • update usages in CI from branch to ref
  • add tests for short- and long-form commit hashes
  • update commit.yml and release.yml test jobs to use --dist loadfile
    • tests in test_generate_tests.py can't run in parallel due to pytest-virtualenv

@wpbonelli wpbonelli force-pushed the generate-classes branch 2 times, most recently from a10b6c7 to 926f59a Compare August 5, 2023 05:18
@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #1907 (bd7d94b) into develop (8084b67) will decrease coverage by 0.1%.
Report is 4 commits behind head on develop.
The diff coverage is 8.3%.

❗ Current head bd7d94b differs from pull request most recent head ce681d6. Consider uploading reports for the commit ce681d6 to get more accurate results

@@            Coverage Diff            @@
##           develop   #1907     +/-   ##
=========================================
- Coverage     72.6%   72.5%   -0.1%     
=========================================
  Files          257     257             
  Lines        56234   56243      +9     
=========================================
+ Hits         40829   40830      +1     
- Misses       15405   15413      +8     
Files Changed Coverage Δ
flopy/mf6/utils/generate_classes.py 16.8% <8.3%> (-0.6%) ⬇️

@wpbonelli wpbonelli force-pushed the generate-classes branch 3 times, most recently from c6edd53 to 72f1bc0 Compare August 5, 2023 18:33
@wpbonelli wpbonelli marked this pull request as ready for review August 5, 2023 19:08
@wpbonelli wpbonelli requested a review from mwtoews August 7, 2023 16:15
@wpbonelli
Copy link
Member Author

possibly relevant to #1629

Copy link
Contributor

@mwtoews mwtoews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

flopy/mf6/utils/generate_classes.py Outdated Show resolved Hide resolved
Co-authored-by: Mike Taves <mwtoews@gmail.com>
@wpbonelli wpbonelli merged commit 7237026 into modflowpy:develop Aug 9, 2023
@wpbonelli wpbonelli deleted the generate-classes branch August 9, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants