-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(exchange and gnc package cellids) #1866
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1866 +/- ##
=========================================
- Coverage 72.3% 72.2% -0.1%
=========================================
Files 256 256
Lines 56112 56133 +21
=========================================
+ Hits 40575 40584 +9
- Misses 15537 15549 +12
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't follow all the low-level changes, but if this allows the example problem to work correctly, then it seems okay. I don't see any comparison of the simulated output to a known solution. Do we need that somehow? If not, then go ahead and merge.
I think my tests that flopy reads and writes correctly are sufficient. Having some problems merging this PR with develop, so I am going to close it and open a new PR for this. |
Fixed exchange and gnc package cellids to resolve model number properly, for simulations with multiple models (#1841)