update(intersect): update to raise error only when interface is called improperly #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1489 +/- ##
==============================================
- Coverage 70.827% 29.940% -40.887%
==============================================
Files 250 250
Lines 54002 52535 -1467
==============================================
- Hits 38248 15729 -22519
- Misses 15754 36806 +21052
|
jdhughes-usgs
requested changes
Aug 9, 2022
|
The Windows/Python3.10 CI failure looks like something I introduced in a recent PR. The cache miniconda step is trying to hash the entire flopy module to check for changes, rather than just I can fix in a PR later today, unless you want to here @jlarsen-usgs |
|
Updated the CI. Thanks for the help @w-bonelli |
|
I reran CI jobs due to more flakiness in the tests for
I removed the |
|
Thanks for the info @w-bonelli, it seems to be a similar transient network issue. I'll apply some more internal retry logic for this HTTP error. Not sure when I'll get this done, could be a couple of days, so feel free to re-add |
wpbonelli
added a commit
to wpbonelli/flopy
that referenced
this pull request
Aug 10, 2022
* use pytest-benchmark's builtin profiling capability instead of manual implementation * remove requires_exe(mf6) from test_mf6.py tests that don't run models/simulations * add @requires_spatial_reference marker to conftest.py (for tests depending on spatialreference.org) * try both importlib.import_module and pkg_resources.get_distribution in @requires_pkg marker * mark test_lgr.py::test_simple_lgr_model_from_scratch as flaky (occasional forrtl error (65): floating invalid) * split test_export.py::test_polygon_from_ij into network-bound and non-network-bound cases * add comments to flaky tests with links to potentially similar issues * add timeouts to CI jobs (10min for build, lint, & smoke, 45min for test, 90min for daily jobs) * remove unneeded markers from pytest.ini * match profiling/benchmarking test files in pytest.ini * mark get-modflow tests as flaky (modflowpy#1489 (comment)) * various tidying/cleanup
wpbonelli
added a commit
to wpbonelli/flopy
that referenced
this pull request
Aug 10, 2022
* use pytest-benchmark's builtin profiling capability instead of manual implementation * remove requires_exe(mf6) from test_mf6.py tests that don't run models/simulations * add @requires_spatial_reference marker to conftest.py (for tests depending on spatialreference.org) * try both importlib.import_module and pkg_resources.get_distribution in @requires_pkg marker * mark test_lgr.py::test_simple_lgr_model_from_scratch as flaky (occasional forrtl error (65): floating invalid) * split test_export.py::test_polygon_from_ij into network-bound and non-network-bound cases * add comments to flaky tests with links to potentially similar issues * add timeouts to CI jobs (10min for build, lint, & smoke, 45min for test, 90min for daily jobs) * remove unneeded markers from pytest.ini * match profiling/benchmarking test files in pytest.ini * mark get-modflow tests as flaky (modflowpy#1489 (comment)) * cache benchmark results in daily CI and compare with prior runs * various tidying/cleanup
wpbonelli
added a commit
that referenced
this pull request
Aug 10, 2022
test: update pytest framework
* use pytest-benchmark's builtin profiling capability instead of manual implementation
* remove requires_exe("mf6") from test_mf6.py tests that don't run models/simulations
* add @requires_spatial_reference marker to conftest.py (for tests depending on spatialreference.org)
* split test_export.py::test_polygon_from_ij into network-bound and non-network-bound cases
* try both importlib.import_module and pkg_resources.get_distribution in @requires_pkg marker
* mark test_lgr.py::test_simple_lgr_model_from_scratch as flaky (occasional forrtl error (65): floating invalid)
* add comments to flaky tests with links to potentially similar issues
* remove unneeded markers from pytest.ini
* match profiling/benchmarking test files in pytest.ini
* mark get-modflow tests as flaky (#1489 (comment))
* add timeouts to CI jobs (10min for build, lint, & smoke, 45min for test, 90min for daily jobs)
* cache benchmark results in daily CI and compare with prior runs
* fix benchmark CI artifact names
* various tidying/cleanup
wpbonelli
added a commit
to wpbonelli/flopy
that referenced
this pull request
Aug 10, 2022
* use pytest-benchmark's builtin profiling capability instead of manual implementation * remove requires_exe(mf6) from test_mf6.py tests that don't run models/simulations * add @requires_spatial_reference marker to conftest.py (for tests depending on spatialreference.org) * try both importlib.import_module and pkg_resources.get_distribution in @requires_pkg marker * mark test_lgr.py::test_simple_lgr_model_from_scratch as flaky (occasional forrtl error (65): floating invalid) * split test_export.py::test_polygon_from_ij into network-bound and non-network-bound cases * add comments to flaky tests with links to potentially similar issues * add timeouts to CI jobs (10min for build, lint, & smoke, 45min for test, 90min for daily jobs) * remove unneeded markers from pytest.ini * match profiling/benchmarking test files in pytest.ini * mark get-modflow tests as flaky (modflowpy#1489 (comment)) * cache benchmark results in daily CI and compare with prior runs * various tidying/cleanup
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
…mproperly (modflowpy#1489) * update intersect warning to raise error only when interface is called improperly * update VertexGrid and UnstructuredGrid intersect routines * remove "flopy" from hashFiles call in CI
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
…mproperly (modflowpy#1489) * update intersect warning to raise error only when interface is called improperly * update VertexGrid and UnstructuredGrid intersect routines * remove "flopy" from hashFiles call in CI
wpbonelli
pushed a commit
that referenced
this pull request
Dec 14, 2022
…mproperly (#1489) * update intersect warning to raise error only when interface is called improperly * update VertexGrid and UnstructuredGrid intersect routines * remove "flopy" from hashFiles call in CI
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
…mproperly (modflowpy#1489) * update intersect warning to raise error only when interface is called improperly * update VertexGrid and UnstructuredGrid intersect routines * remove "flopy" from hashFiles call in CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1481