fix(rollup-plugin-import-meta-assets): fix #2421 #2422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes rollup-plugin-import-meta-assets ignore references
to directories such as e.g. new URL('./', import.meta.url)
bashmish
reviewed
Aug 24, 2023
| this.warn(error, node.arguments[0].start); | ||
| } else { | ||
| this.error(error, node.arguments[0].start); | ||
| } |
There was a problem hiding this comment.
I think we should instead match only expressions which contain an extension in the path by patching isNewUrlImportMetaUrl method, so that we don't even run into this error
also maybe good to rename isNewUrlImportMetaUrl to isNewUrlAssetUrl
There was a problem hiding this comment.
this comment address this, so I'm OK with the current check for EISDIR
bashmish
requested changes
Aug 24, 2023
| this.warn(error, node.arguments[0].start); | ||
| } else { | ||
| this.error(error, node.arguments[0].start); | ||
| if (error.code !== 'EISDIR') { |
There was a problem hiding this comment.
I'd add a comment that this ignores dirs and needs to be done like this to have confidence it's a dir on the file system level (like a summary of #2421 (comment))
There was a problem hiding this comment.
actually, you can also make a test by creating a file without an extension and making sure it's processed correctly
…ts w/o filename extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes rollup-plugin-import-meta-assets ignore references to directories such as e.g.
new URL('./', import.meta.url)