-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCP/IP server support #296
TCP/IP server support #296
Conversation
472a029
to
75f28a1
Compare
75f28a1
to
1cbff3f
Compare
@tbeu The PR should be fine now and is ready to be merged in. I tested with Dymola on Windows and with OpenModelica on Windows and Linux. If you like you can check if everything works for SimulationX, too. |
Will do. What is the timeline for v1.8.0? |
The end of the first October week seems realistic (without STM32 support). Should maybe have a milestone "undecided" for features where the timeline is very unclear. |
f999586
to
f442406
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please rename
- MDD_TCPIPServer_read -> MDD_TCPIPServer_Read
- MDD_TCPIPServer_readP -> MDD_TCPIPServer_ReadP
- MDD_TCPIPServer_send -> MDD_TCPIPServer_Send
- MDD_TCPIPServer_sendP -> MDD_TCPIPServer_SendP
to be consistent with the other implementations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd recommend to make TCPIPServerConfig.tcpipserver protected
, too. And I believe the output
is not needed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also tested, that it still works with Cygwin.
Thanks for the review and the fixes! Unfortunately, I didn't manage to finalize the release last week, there were unplanned issues which reduced my free time. So hopefully I'll release something until the end of this week. I'm not sure regarding the proposed renaming of the functions. The naming is not completely consistent in the library. We have a consistent prefix |
PR for #295.