Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Django 3.0 and Python 3.8 to CI #48

Merged
merged 12 commits into from
Dec 9, 2019
Merged

Add Django 3.0 and Python 3.8 to CI #48

merged 12 commits into from
Dec 9, 2019

Conversation

amureki
Copy link
Collaborator

@amureki amureki commented Dec 8, 2019 •
edited
Loading

Fix #45

This PR:

  • Adds Django 3.0 and Python 3.8 to Travis CI
  • Updates Postgres version on Travis (PG 10, postgis 2.5)
  • Switches Travis CI from xenial to bionic (Ubuntu 18.04)
  • Removes obsolete before_install commands
  • Removes Python 3.5 as Django 3.0 does not support it (I don't think we need to support this version)
  • Updates changelog with all changes since 1.0.2

@amureki amureki added the WIP label Dec 8, 2019
@amureki amureki self-assigned this Dec 8, 2019
@amureki amureki removed the WIP label Dec 8, 2019
@amureki amureki requested a review from berinhard December 8, 2019 20:45
@amureki amureki assigned berinhard and unassigned amureki Dec 8, 2019
anapaulagomes
anapaulagomes reviewed Dec 8, 2019
View reviewed changes
Copy link
Contributor

@anapaulagomes anapaulagomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job :) I hope you don't mind my comments

berinhard
berinhard requested changes Dec 9, 2019
View reviewed changes
Copy link
Member

@berinhard berinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I left a comment on the Python 3.5 on tox. What do you think about it?

@amureki
Copy link
Collaborator Author

amureki commented Dec 9, 2019

@anapaulagomes @berinhard thanks for amazing and helpful reviews, as always! 💖
I tried to address your comments, happy to see your response!

berinhard
berinhard approved these changes Dec 9, 2019
View reviewed changes
Copy link
Member

@berinhard berinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I'm good with the PR 👍

anapaulagomes
anapaulagomes approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@anapaulagomes anapaulagomes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🥇 (Sorry, I misclicked the review button @berinhard)

@amureki amureki merged commit 1226160 into master Dec 9, 2019
@amureki amureki deleted the dj30_py38 branch December 9, 2019 21:40
michael-k added a commit to michael-k/model_bakery that referenced this pull request Jul 30, 2020
@michael-k
Add trove classifier for Python 3.8
d912c8b 
Tested since PR model-bakers#48
@michael-k michael-k mentioned this pull request Jul 30, 2020
Merged
amureki pushed a commit that referenced this pull request Aug 5, 2020
@michael-k
Add trove classifier for Python 3.8 (#95)
24c25dc 
Tested since PR #48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anapaulagomes anapaulagomes anapaulagomes approved these changes

@berinhard berinhard Awaiting requested review from berinhard

Assignees

@berinhard berinhard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Django 3.0 support
3 participants
@amureki @berinhard @anapaulagomes